Fix WCT for bower: use Polymer version of sinon.js #3489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarezguille
added a commit
to vaadin/vaadin-ordered-layout
that referenced
this pull request
Feb 10, 2020
Repository github.com/blittle/sinon.js was deleted And bower install fails Workaround for Polymer/tools#3488 While Polymer/tools#3489 isn't merged and released
web-padawan
pushed a commit
to vaadin/vaadin-ordered-layout
that referenced
this pull request
Feb 10, 2020
Repository github.com/blittle/sinon.js was deleted And bower install fails Workaround for Polymer/tools#3488 While Polymer/tools#3489 isn't merged and released
DiegoCardoso
added a commit
to vaadin/vaadin-grid
that referenced
this pull request
Feb 10, 2020
Repository github.com/blittle/sinon.js was deleted And bower install fails Workaround for Polymer/tools#3488 While Polymer/tools#3489 isn't merged and released
DiegoCardoso
added a commit
to vaadin/vaadin-grid
that referenced
this pull request
Feb 10, 2020
Repository github.com/blittle/sinon.js was deleted And bower install fails Workaround for Polymer/tools#3488 While Polymer/tools#3489 isn't merged and released
|
The integration tests are timing out on Chrome 80. This has been happening elsewhere though, see lit/lit#1080 and lit/lit#1078 |
|
@justinfagnani thanks. BTW, am I right that in order to make a release for Bower, this PR should go into (now archived) original web-component-tester repository? At least $ bower search web-component-tester
Search results:
web-component-tester https://github.com/Polymer/web-component-tester.git |
|
@web-padawan I think you're right. cc @dfreedm @usergenic |
|
We've unarchived the old repo and will add this fix there and tag a new release for Bower. |
|
Thanks a lot 🙇 Feel free to close this PR in that case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3488
This is a fix for the critical issue that affects our bower installations:
Ping @justinfagnani @usergenic.